made _handle_cancel more resiliant against changes to _tasks from oth…#346
Merged
made _handle_cancel more resiliant against changes to _tasks from oth…#346
Conversation
Collaborator
Author
edyounis
previously approved these changes
Aug 15, 2025
Member
|
How has the change been holding up? |
- Add check for ResidualsFunction in both multistart methods to ensure the correct cost function is being used - Ensures best parameters are selected based on actual cost values
Collaborator
Author
|
@edyounis I've been finishing up my major cleanup of NTRO, and these changes seem necessary for it to run consistently. I've caught a couple other, rarer, race conditions. |
edyounis
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes occasional hangs resulting from issues with cancelling a task while another thread is completing that task.